chore: Operator serde refactor part 2 #2741
Open
+168
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
============================================
+ Coverage 56.12% 58.62% +2.49%
- Complexity 976 1465 +489
============================================
Files 119 163 +44
Lines 11743 13987 +2244
Branches 2251 2377 +126
============================================
+ Hits 6591 8200 +1609
- Misses 4012 4580 +568
- Partials 1140 1207 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Builds on the changes in part 1 - #2738
Rationale for this change
What changes are included in this PR?
WindowExecto theopSerdeMap. I have a follow up PR fix: MarkWindowExecas incompatible [WIP] #2736 to also addWindowExecgetSupportLeveltoCometOperatorSerdeto match the approach used with expressions. The follow up PR actually implementsgetSupportLevelforWindowExecorg.apache.comet.serde.operatorpackage. Some were moved in Feat: Add CometLocalTableScanExec operator #2735How are these changes tested?